-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for has_many.js #99
Conversation
test: has_many -> recomputePosition chore: change web api test: bindDestroyEvent test: bindRemoveEvent test: bindAddEvent chore: refactored DOM manipulation, deleted useless code test: bindRemoveEventCallBack chore: apply new DOM node to tests test: bindAddEventCallBack refactor: event call back function chore: change mock to spy chore: change mock to spy chore: lint test: initSortable new assert test: bindAddEventCallBack more assertions chore: delete unnecessary code refactor: move html elements to separate file refactor: add html file for test
@ilunglee Hence I cherry-picked my commit to a new branch and made a new PR. I've answered your questions on the older PR, didn't want to force push into it, thought I might delete our conversations (I think it will delete the conversations?). |
@dulerong, Force-pushing won't delete the comments. Please use the same PR (#98), and close this PR. Thanks! |
@ilunglee Will delete this branch later. |
Thanks! Ooops, I meant #97 😆 |
closed in favour of #97 |
test: has_many -> recomputePosition
chore: change web api
test: bindDestroyEvent
test: bindRemoveEvent
test: bindAddEvent
chore: refactored DOM manipulation, deleted useless code
test: bindRemoveEventCallBack
chore: apply new DOM node to tests
test: bindAddEventCallBack
refactor: event call back function
chore: change mock to spy
chore: change mock to spy
chore: lint
test: initSortable new assert
test: bindAddEventCallBack more assertions
chore: delete unnecessary code
refactor: move html elements to separate file
refactor: add html file for test
Pull request type
Please check the type of change your PR introduces:
What is the current behaviour?
Issue Number(s): N/A
Currently does not have test for has_many.js
What is the new behaviour?
Other information
N/A