Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4129] nginx CEDAR Caching #2545

Merged
merged 29 commits into from
May 9, 2024
Merged

[EASI-4129] nginx CEDAR Caching #2545

merged 29 commits into from
May 9, 2024

Conversation

mynar7
Copy link
Contributor

@mynar7 mynar7 commented Apr 15, 2024

EASI-4129, EASI-4130

Changes and Description

  • Implements nginx as a proxy between EASi and CEDAR that caches all GET requests.
  • Implements a community module for nginx that allows for cache invalidation by sending an HTTP PURGE request to any cached endpoint's URL.

How to test this change

Connect to the CMS VPN, start the app using docker-compose as normal, and make sure to set .envrc.local to allow connecting to CEDAR. Requests should cache automatically. Adding/removing users/roles to systems has cache invalidation applied as an example.

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@mynar7 mynar7 requested review from a team as code owners May 8, 2024 19:28
@mynar7 mynar7 requested review from samoddball, Jdwoodson and ClayBenson94 and removed request for a team May 8, 2024 19:28
pkg/cedar/core/client.go Show resolved Hide resolved
pkg/cedar/core/system_summary.go Show resolved Hide resolved
pkg/cedar/core/system_summary.go Outdated Show resolved Hide resolved
Copy link
Contributor

@samoddball samoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 !!! 💰 (cache)

@Jdwoodson
Copy link
Contributor

image

@mynar7 mynar7 merged commit f758bb0 into main May 9, 2024
53 checks passed
@mynar7 mynar7 deleted the EASI-4129/nginx-caching branch May 9, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants