Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-3852] FE: System Profile ATO Subpage #2618

Merged
merged 9 commits into from
Jun 21, 2024

Conversation

downeyn-cms
Copy link
Contributor

EASI-3852

Changes and Description

  • Updated system profile ATO sub page to include new and updated information

How to test this change

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@downeyn-cms downeyn-cms requested a review from a team as a code owner June 5, 2024 21:30
@downeyn-cms downeyn-cms requested review from adamodd and removed request for a team June 5, 2024 21:31
Copy link
Contributor

@adamodd adamodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted just a few things for now

  • This old rule to tweak the shade of .bg-success-dark can be removed

https://github.com/CMSgov/easi-app/blob/dcd4d2e5b9d2e345e02494ecf4434f6cb76733ac/src/views/SystemProfile/components/ATO/index.scss#L15-L17

src/views/SystemProfile/components/ATO/index.tsx Outdated Show resolved Hide resolved
@adamodd
Copy link
Contributor

adamodd commented Jun 11, 2024

Met earlier today for an overview of remaining data points, and probably leaving out the Process Steps section.

@downeyn-cms downeyn-cms merged commit f7bf854 into main Jun 21, 2024
32 checks passed
@downeyn-cms downeyn-cms deleted the EASI-3852/sys-profile-ato-subpage branch June 21, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants