Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOREF/order fetch users #2636

Merged
merged 1 commit into from
Jun 13, 2024
Merged

NOREF/order fetch users #2636

merged 1 commit into from
Jun 13, 2024

Conversation

samoddball
Copy link
Contributor

NOREF

Changes and Description

  • Implement missing order-by-input functionality

How to test this change

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

Copy link
Contributor Author

@samoddball samoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp - if this fixes the shuffle-bug on dev, we'll put this into a common-use function and apply to all one-to-one dataloaders

@samoddball samoddball merged commit d871beb into main Jun 13, 2024
33 checks passed
@samoddball samoddball deleted the NOREF/order_users branch June 13, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants