-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EASI-4486] system intake doc uploads #2691
Conversation
…nch with only system intake(no verify) fresh branch with only system intake(no verify) fresh branch with only system intake(no verify) fresh branch with only system intake(no verify) fresh branch with only system intake(no verify) fresh branch with only system intake(no verify) fresh branch with only system intake(no verify) fresh branch with only system intake
…EASI-4486/system_intake_doc_uploads
Not sure if you were able to see the gql error return, but this is the error I get when I try to reproduce:
|
There is also a script command to scan for viruses if you'd like: Some frontend markup has the uuid in a testid attr, but not this one. Had to inspect for table document ids to get the uuid in this case. |
…EASI-4486/system_intake_doc_uploads
…EASI-4486/system_intake_doc_uploads
if errors.Is(err, sql.ErrNoRows) { | ||
// if the document was deleted, don't error and break | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamodd if you were curious what that issue was. it wasn't on the delete at all. finally realized this morning that it was err no rows on the URL
resolver for a system intake document, and that runs after deletion. in main
, we go straight to S3 for that URL, but in this auth patch, we first check the DB to see who created the document, but it is gone after deletion!
…EASI-4486/system_intake_doc_uploads
…EASI-4486/system_intake_doc_uploads
…EASI-4486/system_intake_doc_uploads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works as-is, but I do wonder if we can clean up the signature of canCreate
to be in-line with canDelete
and canView
.
EASI-4486
Description
How to test this change
EASI_P_USER
roleEASI_D_GOVTEAM
roleEASI_P_USER
roleNote
i forced the virus scan return by doing this
PR Author Checklist
PR Reviewer Guidelines