Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Remove host.docker.internal #2699

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[NOREF] Remove host.docker.internal #2699

merged 1 commit into from
Jul 16, 2024

Conversation

mynar7
Copy link
Contributor

@mynar7 mynar7 commented Jul 15, 2024

NOREF

Description

  • host.docker.internal is a little bit of a pain on WSL, but also we can't use this with k8s, so I'm trying to strip the occurrences from our app. After this we just have the dev scripts that reference it.

How to test this change

  • Run automated tests, test the document uploads locally.

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@mynar7 mynar7 requested a review from Jdwoodson July 15, 2024 20:16
@mynar7 mynar7 requested review from a team as code owners July 15, 2024 20:16
@mynar7 mynar7 requested review from aterstriep and removed request for a team July 15, 2024 20:16
@@ -121,7 +121,7 @@ export const documents: SystemIntakeDocument[] = [
status: SystemIntakeDocumentStatus.AVAILABLE,
uploadedAt: '2023-06-14T18:24:46.310929Z',
url:
'http://host.docker.internal:9004/easi-app-file-uploads/ead3f487-8aaa-47d2-aa26-335e9b560a92.pdf?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=minioadmin%2F20230614%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20230614T184943Z&X-Amz-Expires=900&X-Amz-SignedHeaders=host&X-Amz-Signature=f71d5d63d68958a2bd8526c2b2cdd5abe78b21eb69d10739fe8f8e6fd5d010ec',
'http://localhost:9004/easi-app-file-uploads/ead3f487-8aaa-47d2-aa26-335e9b560a92.pdf?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=minioadmin%2F20230614%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20230614T184943Z&X-Amz-Expires=900&X-Amz-SignedHeaders=host&X-Amz-Signature=f71d5d63d68958a2bd8526c2b2cdd5abe78b21eb69d10739fe8f8e6fd5d010ec',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mock data appears to be for tests only from what I can tell.

@mynar7 mynar7 merged commit 1e0c446 into main Jul 16, 2024
12 checks passed
@mynar7 mynar7 deleted the NOREF/minio-env-address branch July 16, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants