Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Clean Minio files when using db:clean #2701

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ClayBenson94
Copy link
Collaborator

@ClayBenson94 ClayBenson94 commented Jul 16, 2024

NOREF

Description

Updates the scripts/dev db:clean script to also call the minio_mc docker container (which uses mc) to delete all files.

We could make other changes to have this cleaned on application startup, but this change works in isolation and was simple enough to add, so I'm keeping this PR simple!

How to test this change

  • Ensure nothing exists in ./tmp/minio/easi-app-file-uploads/
  • Start the backend with scripts/dev up:backend
  • Run scripts/dev db:seed
    • You should now see a bunch of folders populated in ./tmp/minio/easi-app-file-uploads/
  • Run scripts/dev db:clean
    • You should see the ./tmp/minio/easi-app-file-uploads/ folder is now cleared

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@ClayBenson94 ClayBenson94 requested a review from a team as a code owner July 16, 2024 13:06
@ClayBenson94 ClayBenson94 requested review from mynar7 and removed request for a team July 16, 2024 13:06
@ClayBenson94 ClayBenson94 merged commit 8532c57 into main Jul 16, 2024
12 checks passed
@ClayBenson94 ClayBenson94 deleted the NOREF/clean_minio_db_clean branch July 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants