-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EASI-4457] TRB Advice letter dataloader #2702
[EASI-4457] TRB Advice letter dataloader #2702
Conversation
…p into EASI-4457/newest-trb-req-feedback-dataloader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a question, but otherwise looks great! love the removal of the *store
arg everywhere!
if err != nil { | ||
return nil, err | ||
} | ||
if adviceLetterStatus == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we nil-check all of these? i see they are all dereferenced below
also a curiosity - why remove the goroutines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that opening a zillion channels is probably worse than just writing it synchronously and letting the dataloaders return cached data, but I might be wrong there. @ClayBenson94 do you have any thoughts?
I missed the dereference! I will add checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nil checks added here: ed83b18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If each synchronous call is behind a dataloader it probably boils down to readability more than anything, since each of those calls will probably already be cached for this request
…p into EASI-4457/advice-letter-dataloader
* [EASI-4457] Funding sources dataloader and mapper refactor (#2692) * add funding source dataloader and refactor helpers.OneToMany and Mapper interface * fix store method, call dataloader version in resolver * [EASI-4457] Add dataloader to TRB request form resolver (#2695) add dataloader to trb request form resolver * [EASI-4457] System intake notes dataloader (#2693) update notes resolver to use dataloader, add tests for notes * [EASI-4457] System Intake Actions dataloader (#2694) add dataloader to system intake actions resolver * [EASI 4457] - TRB Request Feedback dataloaders (#2700) * add dataloaders to TRB Feedback * convert slice to postgres array * use dataloaders in status calls * remove unnecessary no rows error check * [EASI-4457] TRB Advice letter dataloader (#2702) * add dataloaders to TRB Feedback * convert slice to postgres array * use dataloaders in status calls * remove unnecessary no rows error check * add dataloaders to advice letter and finish refactoring statuses * sort mock users * nil check statuses * [EASI-4457] TRB attendees dataloaders (#2705) * add dataloader to trb attendees * add dataloader for attendees by EUA and TRB ID, update requester component resolver * use ptr helper, add to resolver test * [EASI-4457] Add closed requests for testing (#2709) * refactor seed data to allow for closed request generation * remove context value and just use a constant * add regex to LCID test * [EASI-4457] TRB documents dataloaders (#2706) * add a dataloader for trb documents, use dataloaders in other resolvers * semicolons and better error handling * [EASI-4457] TRB Admin Notes dataloader (#2714) add dataloaders for TRB admin notes * [EASI-4457] TRB Request Funding Sources dataloader (#2715) * add dataloader for trb funding sources * fix test to allow for empty slice * add TODO comment * [EASI-4457] TRB Form System Intakes dataloader (#2722) add dataloader for trb request form system intakes * [EASI-4457] Add gov req feedback dataloader (#2731) * add gov req feedback dataloader * run gql gen * [EASI-4457] intake documents dataloader (#2732) * add dataloader for documents * use resolver to create fake documents * update seed script * update seed script to not fetch users multiple times for closed requests * add comments * [EASI-4457] Business Case dataloaders (#2729) * refactor business case legacy code to allow for biz case and cost line dataloaders with less friction * cleanup comments --------- Co-authored-by: samoddball <156127704+samoddball@users.noreply.github.com> --------- Co-authored-by: samoddball <156127704+samoddball@users.noreply.github.com>
EASI-4457
Description
How to test this change
adviceLetter
and status fields on TRB Requests or run the automated test suite.PR Author Checklist
PR Reviewer Guidelines