remove unused action option from BE

[samoddball]

NOREF

Description

• progress towards rock - removing REST in favor of GraphQL
• this is a cheap one cause it is removal only, but this seems safe to remove as we have this in the UI as the only usage of postAction:

postAction({
    intakeId: businessCase.systemIntakeId,
    actionType: isFinal
        ? 'SUBMIT_FINAL_BIZ_CASE'
        : 'SUBMIT_BIZ_CASE'
})

and we had this in the BE:

actionHandler := handlers.NewActionHandler(
    base,
    services.NewTakeAction(
        store.FetchSystemIntakeByID,
        map[models.ActionType]services.ActionExecuter{
            models.ActionTypeSUBMITBIZCASE: services.NewSubmitBusinessCase(
                // hidden for brevity
            ),
            models.ActionTypeSUBMITFINALBIZCASE: services.NewSubmitBusinessCase(
                // hidden for brevity
            ),
            models.ActionTypeSUBMITINTAKE: services.NewSubmitSystemIntake(
                // hidden for brevity
            ),
        },
    ),
)

because models.ActionTypeSUBMITINTAKE is not one of the actions sent through postAction, it seems fine to remove before we refactor business case to be completely graphql

How to test this change

PR Author Checklist

• I have provided a detailed description of the changes in this PR.
• I have provided clear instructions on how to test the changes in this PR.
• I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

• It's best to pull the branch locally and test it, rather than just looking at the code online!
• When approving a PR, provide a reason why you're approving it
  • e.g. "Approving because I tested it locally and all functionality works as expected"
  • e.g. "Approving because the change is simple and matches the Figma design"
• Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
• Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

[samoddball]

unused

[samoddball]

no longer needed - only one function on backend regardless of which action

[mynar7]

Nice, can't wait to nix the rest of this old REST code.