-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EASI-4589 Fix the requests table's status column sorting method #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shorten the lcid condition
samoddball
previously approved these changes
Aug 20, 2024
Restore original trb request status
Updated to cover all tables. These are ready since the last review
Made some edits to this table's tableMap so that I could untangle the original trb request status. Eventually planning to phase out tableMap for a more streamlined approach with typing at a later time. |
samoddball
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-4589
Description
Table's status column needs to sort by status enums.
This also introduces
utils/tableRequestStatusIndex.ts
to maintain sort indexes.Tables were initially made to leave status columns up to alphabetical sorting, if at all.
Bug originally found on the ITGOV table.
Before
After
How to test this change
PR Author Checklist
PR Reviewer Guidelines