Easi 4580/email notifications #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EASI-4580/email_notifications
samoddball
commented
Aug 21, 2024
| @@ -184,7 +184,7 @@ exports[`Governance Overview Content > renders default version without crashing | |||
| <p | |||
| class="margin-bottom-1" | |||
| > | |||
| If your Business Case is approved, you will receive a unique Life Cycle ID. If it is not approved, you will recieve documented next steps or concerns to address in order to proceed. | |||
| If your Business Case is approved, you will receive a unique Life Cycle ID. If it is not approved, you will receive documented next steps or concerns to address in order to proceed. | |||
There was a problem hiding this comment.
noticed one of these so fixed everywhere
samoddball
requested review from
mynar7 and
aterstriep
and removed request for
a team
…EASI-4580/email_notifications
…/easi-app into EASI-4580/email_notifications
mynar7
reviewed
Aug 23, 2024
mynar7
reviewed
Aug 23, 2024
mynar7
previously requested changes
Aug 23, 2024
aterstriep
previously requested changes
Aug 23, 2024
There was a problem hiding this comment.
The field needs a few minor changes on the frontend, but overall nice job!
Based on the Figma, the field should be required. It needs an asterisk next to the legend and the validation schema needs to be updated to include this field.
mynar7
added a commit
that referenced
this pull request
Sep 6, 2024
* [EASI-4488] Add new document types to intake form (#2748) * add new document types, adjust form and table, fix minio scripts * fix cypress, remove commented code * use translation to enforce enum options * [EASI-4488] Add permissions to GQL schema for intake documents (#2756) add permissions to GQL schema for intake documents * [EASI-4489] System intake document upload form (#2760) * Add version help text * Update form to match Figma * Add type prop to UploadForm * Admin upload form * Conditional return link * Validation schema * Easi 4580/email notifications (#2774) * UI for selecting if notification should go out * add bool check to BE * fix bool radio * typo * add condition * fix imports * refs * use `field.onChange` instead of `setValue` * trying to fix snapshot * put snap back * added UI tests for UploadForm notification display * add some tests for BE * fix ref, error condition, text * updates to validation * [EASI-4488] GRB Review supporting docs table (#2776) * update queries to include permissions for docs * add documents table * address feedback, update docs table in other places * update snapshot * fix failing cypress test * fix biz case solution rendering and alert padding * rename migration number * [EASI-4591] IT Gov admin route updates (#2781) * governance-review-team -> it-governance * Update subNavItems + context * Route updates * Remove hidden nav links from array * Unit test fixes * Unit tests for action buttons * Redirect for old admin links * Update url in e2e tests * Upload form route * Test file routes * [EASI-4597] Add software BOM to doc types (#2787) add software BOM to doc types * [EASI-4583] GRB review sub navigation links (#2792) * SideNavigation component * RequestOverview side nav - Updated to use SideNavigation component - Added Supporting Documents and Participants links * Child nav link functionality * AccordionNavigation updates * Remove unused CSS * Snapshot Accordion navigation button no longer renders on desktop * I definitely didn't forget this before * e2e test fix * e2e test fix - actions link selector * e2e test fix - lcid link selector * e2e test fix - dates link selector * NOREF - change email link URLs to reference new path (#2795) change email link URLs to reference new path * Update pre-signed S3 url timeout to 90 minutes --------- Co-authored-by: Ashley Terstriep <60187543+aterstriep@users.noreply.github.com> Co-authored-by: samoddball <156127704+samoddball@users.noreply.github.com> Co-authored-by: ClayBenson94 <clay.benson@oddball.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-4580
Description
How to test this change
requesterrole (even if the user is an admin)PR Author Checklist
PR Reviewer Guidelines