[EASI-4468] related systems column #2777

samoddball · 2024-08-23T21:44:42Z

EASI-4468

Description

add Related systems column

How to test this change

this new column only appears on the home page under My open requests
create a system intake and attribute it to one or more systems
create a TRB requests and attribute it to one or more systems
nav to home page and cofirm the related systems are listed out and comma separated

PR Author Checklist

I have provided a detailed description of the changes in this PR.
I have provided clear instructions on how to test the changes in this PR.
I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
When approving a PR, provide a reason why you're approving it
- e.g. "Approving because I tested it locally and all functionality works as expected"
- e.g. "Approving because the change is simple and matches the Figma design"
Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

…dme for `sqlqueries`

…new types

samoddball · 2024-08-26T19:50:27Z

pkg/sqlqueries/README.md

@@ -0,0 +1,3 @@
+### Package `sqlqueries`


moved from an empty go file with same (similar) documentation

samoddball · 2024-08-28T15:04:07Z

pkg/storage/system_intake.go

+func (s *Store) GetMySystemIntakes(ctx context.Context) ([]*models.SystemIntake, error) {
+	var intakes []*models.SystemIntake
+
+	err := namedSelect(ctx, s, &intakes, sqlqueries.SystemIntake.GetByUser, args{
+		"eua_user_id": appcontext.Principal(ctx).Account().Username,
+	})
+
+	return intakes, err
+}


core BE change

samoddball · 2024-08-28T15:05:26Z

pkg/graph/resolvers/system_intake.go

+func GetMySystemIntakes(ctx context.Context, store *storage.Store) ([]*models.SystemIntake, error) {
+	return store.GetMySystemIntakes(ctx)
+}


core BE change

samoddball · 2024-08-28T15:06:10Z

src/views/MyRequests/Table/index.tsx


 import '../index.scss';

+const calcSystemIntakeNextMeetingDate = (


core UI change

samoddball · 2024-08-28T15:06:19Z

src/views/MyRequests/Table/index.tsx


-  const columns: any = useMemo(() => {
+  const columns: Column<MergedRequestsForTable>[] = useMemo<


core UI changes in here

samoddball · 2024-08-28T15:06:30Z

src/views/MyRequests/Table/mergedRequestForTable.ts

@@ -0,0 +1,10 @@
+export interface MergedRequestsForTable {


new type for merged types

…EASI-4468/related_systems_column

aterstriep

Nice job!

Can you take a look at the table code to see if you can make the column a bit wider to match the Figma? Probably not worth holding this up unless it's a quick fix. I'll go ahead and approve since everything else looks good on the frontend.

…EASI-4468/related_systems_column

samoddball · 2024-08-28T21:24:02Z

Nice job!

Can you take a look at the table code to see if you can make the column a bit wider to match the Figma? Probably not worth holding this up unless it's a quick fix. I'll go ahead and approve since everything else looks good on the frontend.

Good call! Thanks!

Column widened

aterstriep

Thanks for making that change! Everything looks good 👍🏻

samoddball added 5 commits August 22, 2024 09:00

little bit of cleanup

643b925

building out sql and storage. removed empty go file in place of a rea…

7b5b42a

…dme for `sqlqueries`

(no verify) think i have BE done, flipping to UI to update table for …

41b4dd6

…new types

working through merged types

3624c81

(no verify) fix missing embed (whoops), working on merged table types

af374e7

samoddball temporarily deployed to test August 23, 2024 21:44 — with GitHub Actions Inactive

reincorporate type

acb8753

samoddball temporarily deployed to test August 23, 2024 21:50 — with GitHub Actions Inactive

remove unused, cleanup data builder

e355ea6

samoddball temporarily deployed to test August 23, 2024 22:19 — with GitHub Actions Inactive

separate out type

ad58750

samoddball temporarily deployed to test August 23, 2024 22:26 — with GitHub Actions Inactive

fix dates

b649edb

samoddball temporarily deployed to test August 26, 2024 17:43 — with GitHub Actions Inactive

dd systems col, fix links + types

0e7975c

samoddball temporarily deployed to test August 26, 2024 17:53 — with GitHub Actions Inactive

hide systems col on itgov specific page, fix tests

228f3c7

samoddball temporarily deployed to test August 26, 2024 18:08 — with GitHub Actions Inactive

samoddball changed the title ~~Easi 4468/related systems column~~ [EASI-4468] related systems column Aug 26, 2024

samoddball marked this pull request as ready for review August 26, 2024 19:41

samoddball requested review from a team as code owners August 26, 2024 19:41

samoddball requested review from mynar7 and aterstriep and removed request for a team August 26, 2024 19:41

samoddball commented Aug 26, 2024

View reviewed changes

samoddball commented Aug 28, 2024

View reviewed changes

Merge branch 'main' of https://github.com/CMS-Enterprise/easi-app into …

d27f275

…EASI-4468/related_systems_column

samoddball temporarily deployed to test August 28, 2024 16:43 — with GitHub Actions Inactive

cypress test

b052efb

samoddball temporarily deployed to test August 28, 2024 19:06 — with GitHub Actions Inactive

aterstriep previously approved these changes Aug 28, 2024

View reviewed changes

samoddball added 2 commits August 28, 2024 12:19

Merge branch 'main' of https://github.com/CMS-Enterprise/easi-app into …

f2b07a3

…EASI-4468/related_systems_column

run gql

14f9bf2

samoddball dismissed aterstriep’s stale review via 14f9bf2 August 28, 2024 19:29

Merge branch 'main' of https://github.com/CMS-Enterprise/easi-app into …

e4cb0c1

…EASI-4468/related_systems_column

samoddball temporarily deployed to test August 28, 2024 21:03 — with GitHub Actions Inactive

widen col

380f33f

samoddball temporarily deployed to test August 28, 2024 21:23 — with GitHub Actions Inactive

samoddball requested a review from aterstriep August 28, 2024 21:24

fix snap

f1b759f

samoddball temporarily deployed to test August 28, 2024 22:23 — with GitHub Actions Inactive

aterstriep approved these changes Aug 29, 2024

View reviewed changes

samoddball merged commit c7dd74b into main Aug 29, 2024
12 checks passed

samoddball deleted the EASI-4468/related_systems_column branch August 29, 2024 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EASI-4468] related systems column #2777

[EASI-4468] related systems column #2777

samoddball commented Aug 23, 2024 •

edited

Loading

samoddball Aug 26, 2024

samoddball Aug 28, 2024

samoddball Aug 28, 2024

samoddball Aug 28, 2024

samoddball Aug 28, 2024

samoddball Aug 28, 2024

aterstriep left a comment

samoddball commented Aug 28, 2024

aterstriep left a comment


		import '../index.scss';

		const calcSystemIntakeNextMeetingDate = (


		const columns: any = useMemo(() => {
		const columns: Column<MergedRequestsForTable>[] = useMemo<

[EASI-4468] related systems column #2777

[EASI-4468] related systems column #2777

Conversation

samoddball commented Aug 23, 2024 • edited Loading

EASI-4468

Description

How to test this change

PR Author Checklist

PR Reviewer Guidelines

samoddball Aug 26, 2024

Choose a reason for hiding this comment

samoddball Aug 28, 2024

Choose a reason for hiding this comment

samoddball Aug 28, 2024

Choose a reason for hiding this comment

samoddball Aug 28, 2024

Choose a reason for hiding this comment

samoddball Aug 28, 2024

Choose a reason for hiding this comment

samoddball Aug 28, 2024

Choose a reason for hiding this comment

aterstriep left a comment

Choose a reason for hiding this comment

samoddball commented Aug 28, 2024

aterstriep left a comment

Choose a reason for hiding this comment

samoddball commented Aug 23, 2024 •

edited

Loading