-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EASI-4549] System workspace "Team" card #2778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an existing InitialsIcon
component that we use in a couple of other places. Can you update those instances to use Avatar
instead since the ticket says users should have the same color across the app? That way we can go ahead and remove InitialsIcon
so we don't have two mostly duplicate components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay didn't notice that. Avatar has the new colors we want? And swapping out InitialsIcon is probably good to go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just went for it. The only thing I caught was this font-body-2xs
difference
`easi-initials-icon display-flex flex-align-center flex-justify-center font-body-2xs circle-4 ${colorClass}`, |
Not sure if it should've stayed. If so looks ready to pass back in.
src/utils/getUsernamesWithRoles.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to bring this up into a util function 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍🏻
EASI-4549
https://www.figma.com/design/z8GeZPDfIh9oKfHK1cX7Fo/System-centric-EASi?node-id=4239-8187&t=b9iFjrGAECM00YdC-0
Description
SystemWorkspace/TeamCard
teamRolesIndex
Avatar
from MintHow to test this change
PR Author Checklist
PR Reviewer Guidelines