AB2D-5819/Create cron job to run AttributionDataShare procedure on the database #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database changes for AttributionDataShare Lambda
| for values in (2023); | ||
|
|
||
| create table if not exists tst_2023 partition of tst |
There was a problem hiding this comment.
Should the create statement here and on line 27 be checking against the upcoming year instead of tst_2023?
Ex:
create table if not exists tst_2024 partition of tst
create table if not exists tst_2025 partition of tst
There was a problem hiding this comment.
oops! I mistyped
Fixed
| end; | ||
| $$; | ||
| -- | ||
| -- CREATE OR REPLACE PROCEDURE update_current_mbi_2024() |
There was a problem hiding this comment.
Would it be an option to put this in a new v2024 directory, similar to the ones in here instead of having this commented out in the v2023/... folder?
kyeah
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-5819
🛠 Changes
ℹ️ Context for reviewers
Due to deployment issue we had to revert 2 PR:
#1295
#1294
In this PR, I have included changes for partitions, a new table and procedure that were previously reviewed and approved.
I commented out create_pg_cron_extension.sql in liquibase changelog, because testing is currently blocked by
PLT-246 Set pg_cron in parameter group for AB2D DBs.
We will test the scheduled procedure call in a follow up ticket: AB2D-5868
Test cron job to run AttributionDataShare procedure on the database
✅ Acceptance Validation
I've deployed this branch on dev environment and ran a job
Job completed without any exceptions.
Database contains new partitions, new table and procedure
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.