[DPC-4434] Bump junit.jupiter to 5.11.3 #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aren't we going to need to fix the tests in order to merge? |
Yep, and in the meantime we should probably stop merging new code until it's done. |
MEspositoE14s
commented
Dec 13, 2024
| @@ -33,12 +34,12 @@ public SecretLoggingFilter() { | |||
| @Override | |||
| public Filter<ILoggingEvent> build() { | |||
| // Clean the secrets list | |||
| secrets.removeIf(secret -> !envVars.containsKey(secret)); | |||
| List<String> containsSecrets = secrets.stream().filter(envVars::containsKey).collect(Collectors.toList()); | |||
There was a problem hiding this comment.
Still an improvement over the iterator!
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| <properties> | |||
| <mainClass>gov.cms.dpc.api.DPCAPIService</mainClass> | |||
| <jjwt.version>0.12.6</jjwt.version> | |||
| <jjwt.version>0.11.4</jjwt.version> | |||
There was a problem hiding this comment.
reverting this to the version we had before, as there's some signing key issues in JWTUnitTests that will take some refactoring to resolve
|
JJWT changes basically undo most of the changes from THIS PR. |
lukey-luke
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4434
🛠 Changes
Bump junit-jupiter to 5.11.3 to get our integration tests running again.
ℹ️ Context
When running
make ci-app, both locally and as part of the Github build process our tests haven't been running. This was because the most recent bump of Drop Wizard brought in a transitive dependency on junit-jupiter 5.11.3, and we were running 5.10.2. This conflict doesn't cause a failure, but it does prevent Junit from finding any of our tests. This PR bumps our version to match the one pulled in from Drop Wizard and gets our tests running again.Note
This change was merged on 11/26 and our tests haven't been running ever since. We're going to have to go back and fix any potential failing tests we've introduced since then.
🧪 Validation