[DPC-4427] Fetch bearer token for load testing #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-ronning-ny
changed the title
Makefile
Outdated
| @@ -112,7 +112,7 @@ start-portals: start-db start-web start-admin start-portal | |||
|
|
|||
| start-load-tests: ## Run DPC performance tests locally in a Docker image provided by Grafana/K6 | |||
| start-load-tests: | |||
| @docker run --rm -i grafana/k6 run - <./dpc-load-testing/script.js | |||
| @docker run --rm -v $(shell pwd)/dpc-load-testing:/src --env-file $(shell pwd)/dpc-load-testing/.env -i grafana/k6 run /src/script.js | |||
There was a problem hiding this comment.
Could store in ansible then
maybe change to
-e CLIENT_TOKEN=$LOAD_TEST_TOKEN ...
There was a problem hiding this comment.
The Makefile has no way to understand what $LOAD_TEST_TOKEN should be coming from. This whole thing isn't defined in a docker-compose.yml, but rather, it's run in grafana's own docker image.
As a result, I had to point --env-file at the decrypted env.local.
…ct the need for specificity in ansible vault
|
@jdettmannnava updated to use ansible. |
jdettmannnava
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4427
🛠 Changes
ℹ️ Context
In order to enable load testing the DPC API, we need an organization in the test environment that can authenticate. This PR validates that this new organization is functional; it relies on the organization's client token, public key ID, and RSA private key, which are stored in secrets, and accessed by the GitHub Actions workflow in question.
🧪 Validation