Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coherence name with OZ #211

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Coherence name with OZ #211

merged 5 commits into from
Aug 7, 2023

Conversation

rya-sge
Copy link
Collaborator

@rya-sge rya-sge commented Jul 28, 2023 •
edited
Loading

closes #174
Contains the PR #208

  • Update the different arguments name as indicated in the issue
  • Update the documentation with the different changes, included the changes brought by the batch functions
  • Update and Improve the documentation of Mint, Burn and ERC20BaseModule
    This PR includes also small code improvements:
  • In approve Call _approve instead of the public function from OpenZeppelin to reduce cost gaz.

@rya-sge rya-sge changed the base branch from master to dev July 28, 2023 13:57
@rya-sge rya-sge requested a review from veorq July 31, 2023 09:04
@rya-sge rya-sge self-assigned this Jul 31, 2023
@rya-sge rya-sge changed the title Coherence name Coherence name with OZ Jul 31, 2023
@rya-sge rya-sge added the Update Update a library label Aug 3, 2023
@rya-sge rya-sge merged commit a4c660f into dev Aug 7, 2023
1 check failed
@rya-sge rya-sge mentioned this pull request Aug 23, 2023
Merged
10 tasks
@rya-sge rya-sge deleted the coherence-name branch January 18, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veorq veorq veorq approved these changes

Assignees

@rya-sge rya-sge

Labels
Update Update a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coherence name with OpenZeppelin
2 participants
@rya-sge @veorq