Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the function kill #221

Merged
merged 6 commits into from
Sep 4, 2023
Merged

Remove the function kill #221

merged 6 commits into from
Sep 4, 2023

Conversation

rya-sge
Copy link
Collaborator

@rya-sge rya-sge commented Sep 1, 2023

The function kill is removed from the baseModule
The function deactivateContract is added to the PauseModule to deactivate the contract.

Details
Add a boolean isDeactivated
A new function deactivateContract , restricted to the admin, can be used to deactivate the contract
This function set the variable isDeactivated to true.
In standalone mode, this operation is irreversible, it is not possible to rollback.
With a proxy, it is still possible to rollback by deploying a new implementation.
This function puts also the contract in the pause state
The variable isDeactivated has also an impact on the function unpause. This one will revert if the previous variable is set to true, thus the contract is in the pause state forever.

closes #210

@rya-sge rya-sge changed the base branch from master to dev September 1, 2023 11:52
@rya-sge rya-sge self-assigned this Sep 1, 2023
@rya-sge rya-sge added Security Update Update a library labels Sep 1, 2023
@rya-sge rya-sge merged commit 4b11c22 into dev Sep 4, 2023
1 check passed
@rya-sge rya-sge mentioned this pull request Sep 4, 2023
10 tasks
@rya-sge rya-sge deleted the remove-kill branch September 26, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Security Update Update a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants