Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries #40

Merged
merged 16 commits into from
Oct 13, 2022
Merged

Update libraries #40

merged 16 commits into from
Oct 13, 2022

Conversation

rya-sge
Copy link
Collaborator

@rya-sge rya-sge commented Sep 26, 2022

Update the libraries

#31
The branch contains the pull request #45

- Fix bugs in tests by adding the keyword await
- Set default gas limit in SnapShotModule.test.js for some functions because tests failed for lack of gas.
- Update all the libraries
- Update the solidity version (0.8.2 -> 0.8.4)
- Update the versions in the README
@rya-sge
Copy link
Collaborator Author

rya-sge commented Sep 26, 2022

Status: all libraries are up to date (except OpenZeppelin and eth sig util)
There remains a test that fails in MetaTxModule

@rya-sge rya-sge self-assigned this Sep 26, 2022
@veorq veorq mentioned this pull request Sep 30, 2022
@rya-sge rya-sge changed the title [WIP] Update library Update library Oct 4, 2022
@rya-sge rya-sge requested a review from veorq October 4, 2022 08:14
@rya-sge
Copy link
Collaborator Author

rya-sge commented Oct 4, 2022

Ready to merge.
For one library, 'eth-sig-util', it was not possible to use the new version of the library "@metamask/eth-sig-util". I don't manage to make the test "MetaTxModule.test.js" works. The check of the signature fails (line 90).

@rya-sge rya-sge changed the title Update library Update libraries Oct 5, 2022
@rya-sge rya-sge added the Update Update a library label Oct 5, 2022
@rya-sge rya-sge mentioned this pull request Oct 5, 2022
@rya-sge rya-sge requested a review from skrafft October 11, 2022 08:07
@rya-sge rya-sge merged commit 5f047cf into master Oct 13, 2022
@rya-sge rya-sge deleted the update-library branch October 13, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Update a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants