Improve CMake #9
Conversation
|
Since the workflow is currently not in the default branch, gh workflow run "Docker Build and Test" --ref <branch> -f use_cache=falseTest workflow with skipped |
| add_executable(rawhash2 wrapper_example.cpp) | ||
| target_link_libraries(rawhash2 PRIVATE rawhash2_lib) | ||
| set_target_properties(rawhash2 PROPERTIES INSTALL_RPATH $ORIGIN/../lib) | ||
| install(TARGETS rawhash2 RUNTIME DESTINATION bin) |
There was a problem hiding this comment.
Currently make install would install the shared library and also an executable that links to it. Should we install an executable that doesn't link to the rawhash2 shared library as well? Also generally what's the reason to build both rawhash2_builtin (former rawhash2) and rawhash2 (former rawhash2_usinglib) targets?
There was a problem hiding this comment.
Yes, you can build a shared and static library. The python wrapper needs a shared library, if I remember well.
The important thing is that both the rawhash python wrapper and rawhash cli can be built at the same time, unlike previously.
I used rawhash_lib, so that it can be included as a library in both the cli and the python wrapper, but this is not necessary if the above goal is met.
There was a problem hiding this comment.
Yes, we should be able to build both currently. What I'm really asking is: During the install, should we install both the "standalone" client and the client that depends on the static library, or only one of them? If only one, which? Would it be okay to only install the client that depends on RawHash shared library?
Pull request for fixes for #7.