Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of the modulated-development branch #261

Open
vaitkus opened this issue Oct 8, 2021 · 3 comments
Open

Removal of the modulated-development branch #261

vaitkus opened this issue Oct 8, 2021 · 3 comments

Comments

@vaitkus
Copy link
Collaborator

vaitkus commented Oct 8, 2021

Development of the modulated structure dictionary (cif_ms.dic) was moved to a separate repository [1], however, the 'modulated-development' branch [2] of this repository still contains some unmerged changes relating to the aforementioned dictionary. Relevant changes should be cherry-picked and merged. Note, that the templ_attr.cif file that still belongs to this repository was also slightly changed.

A similar issue was also raised in the CIF_MS repository (COMCIFS/Modulated_Structures/issues/2).

[1] https://github.com/COMCIFS/Modulated_Structures
[2] https://github.com/COMCIFS/cif_core/tree/modulated-development

@vaitkus
Copy link
Collaborator Author

vaitkus commented Jul 20, 2023

Changes from that branch are now available in two different PRs:

@vaitkus
Copy link
Collaborator Author

vaitkus commented Sep 8, 2023

Changes made to the MS_DIC have been successfully merged with PR COMCIFS/Modulated_Structures#3.

@vaitkus
Copy link
Collaborator Author

vaitkus commented Sep 11, 2023

As all of the features from the modulated-development branch have been merged, the branch can most likely be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant