Add changes from the 'modulated-development' branch (CIF_CORE) #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes taken from the 'modulated-development' branch [1] and adapted to the latest version of the dictionary in this repository. I am not sure if any of those changes are still relevant, but I wanted to address them before making any more significant changes to the dictionary. From what I can tell from the log messages of the original branch, the changes in question were originally suggested by G. Madariaga.
The default Git diff does quite a bad job of properly conveying the changes (e.g. it shows significant changes to existing data items instead of addition of new data items), therefore it might be more convenient to use the simple (*nix) diff command to compare the dictionary in this branch with the dictionary in the master branch.
Changes taken from the
CIF_CORE
branch include the addition of new data items and categories, addition of new dREL code (related to the added items) and the change of theATOM_SITE_U_FOURIER
category key.The list of added categories and items:
Also, it should be noted, that the original branch did not (yet) contain some of the items that are now included in the dictionary, so it is possible that they were either replaced by or added instead of the new items and categories in this PR,
e.g.
atom_site_displace_Legendre.coeff
instead ofATOM_SITE_DISPLACE_LEGENDRE_PARAM
category. This PR does NOT remove these items. Items in question:The original branch also included some changes that were NOT included in this PR:
_type.purpose
attribute. If needed, I can include those in the PR as well, but at this point is probably be more convenient to just go over the entire item list again and double checks if anything seems out of order.[1] https://github.com/COMCIFS/cif_core/tree/modulated-development
@jamesrhester, maybe you recall the purpose behind the original branch and if it is still relevant? Also, should I include the changes to the Item purposes and addition of alias or is it OK to leave them out?