-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
templ_enum.cif: add _units.code
to save frames
#391
Comments
I don't understand the suggestion. Perhaps you could give an example? |
@jamesrhester sorry for being unclear. I suggest adding the |
Yes, I see now. I agree that this is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be useful to have the units of measure in the same save frame as the enumerated values since the same save frame may potentially be imported by multiple definitions. This is probably most useful in the
atomic_mass
,radius_bond
andlength_neutron
save frames (and potentially inelectron_count
to make it clear that is unitless and not measured in electrons).The
_units.code
can still be retained in the importing save frames and simply ignored or replaced depending on the import mode.The text was updated successfully, but these errors were encountered: