-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add units to templ_enum.cif #396
Conversation
but questions still remain
Just exploring this idea. Found some issues around units. |
One thing that we need to decide on before merging is if we want to only have they units in the @jamesrhester , @rowlesmr do you have any opinion on the topic? |
Having units in both places maximises readbility, but sacrifices robustness. How is the documentation generated? ie, will the units_code explicitly given in Vol G / the website (eg https://www.iucr.org/__data/iucr/cifdic_html/1/cif_core.dic/Iatom_type_scat_length_neutron.html) I'm assuming it is A Big Deal to change from replace-on-duplicate? |
I strongly believe the units should only be in one place. A very recent decision is that the released dictionary as it appears on the IUCr website will have all of the mode=Contents imports resolved in place, so the readability should not suffer. I am planning that the release files that Github lists will also have these resolved, but haven't got around to figuring out how that works in Github yet. I think that means that moving the units to the |
This PR serves as an example for issue #391.