Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default values for author identifiers #359

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Provide default values for author identifiers #359

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
703d728
Provide default values for author identifiers
jamesrhester Mar 20, 2023
408510f
Add dREL to create keys for legacy author categories
jamesrhester Mar 22, 2023
63c651f
Improve dREL for _audit_contact_author.id
jamesrhester Mar 23, 2023
81a56ff
Minor dREL improvement
jamesrhester Mar 23, 2023
0d0537b
Update dREL code of _publ_contact_author.id.
vaitkus Mar 23, 2023
abb2de2
Use new Unique_id function for creating missing author ids
jamesrhester Mar 30, 2023
d05288f
Add the object identifier part in the Current_row() subroutine call.
vaitkus Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions cif_core.dic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14978,6 +14978,11 @@ save_audit_author.id
_type.source Related
_type.container Single
_type.contents Word
_method.purpose Definition
_method.expression
;
_enumeration.default = Current_Row(audit_author) + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Unique_id function (COMCIFS/dREL#10) might be more suitable here.

If not, the Current_row() call should be updated to reflect the changes implemented in COMCIFS/dREL#9.

;

save_

Expand Down Expand Up @@ -15345,6 +15350,25 @@ save_audit_contact_author.id
_type.source Related
_type.container Single
_type.contents Word
_method.purpose Definition
_method.expression
;
with aca as audit_contact_author
count = 0
target = 0
jamesrhester marked this conversation as resolved.
Show resolved Hide resolved
loop aa as audit_author {
if (aca.name == aa.name) {
count++
target = aa.id
}
}
if (count == 0 || count > 1) {
_enumeration.default = missing
}
else {
_enumeration.default = target
}
jamesrhester marked this conversation as resolved.
Show resolved Hide resolved
;

save_

Expand Down Expand Up @@ -18456,6 +18480,11 @@ save_publ_author.id
_type.source Related
_type.container Single
_type.contents Word
_method.purpose Definition
_method.expression
;
_enumeration.default = Current_Row(publ_author) + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Unique_id function (COMCIFS/dREL#10) might be more suitable here.

If not, the Current_row() call should be updated to reflect the changes implemented in COMCIFS/dREL#9.

;

save_

Expand Down Expand Up @@ -18851,6 +18880,25 @@ save_publ_contact_author.id
_type.source Related
_type.container Single
_type.contents Word
_method.purpose Definition
_method.expression
;
with pca as publ_contact_author
count = 0
target = 0
loop pa as publ_author {
if (pca.name == pa.name) {
count++
target = pa.id
}
}
if (count == 0 || count > 1) {
_enumeration.default = missing
}
else {
_enumeration.default = target
}
;

save_

Expand Down