Redefine cell measurement wavelength as measurand #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redefines the
_cell_measurement.wavelengthdata item as a measurand and adds the corresponding SU item. While this data item is already deprecated, it makes sense to still correct this issue for consistency (_cell_measurement.temperature,_cell_measurement.pressureand the_diffrn_radiation_wavelength.valuedata item that superseded_cell_measurement.wavelengthall allows SU values).Note, that the definition of this data item in the DDL1 dictionary also did not allow SU value, but I have opened a separate PR in the DDL1 legacy dictionary repository to fix this (COMCIFS/DDL1-legacy-dictionaries#9) that can be merged once/if this PR is approved.