Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues:
Head
save frame from thecif_ms.dic
dictionary. Previously, the data block name was incorrectly provided.cif_ms.dic
dictionary. This is probably the intended behaviour. Note, that under this mode, even if the definition of a duplicate category is ignored, non-duplicate items from that category are still imported.Additional things to address:
ATOM_SITE_FOURIER_WAVE_VECTOR
category key had to be explicitly specified in this dictionary as well (that part of the definition was copied from thecif_ms.dic
dictionary. Maybe it would make sense to also copy the full definition of the_atom_site_Fourier_wave_vector.seq_id
data item?CIF_CORE
category is a bit redundant since it is already imported in full by theCIF_MS
dictionary.