Mostly style changes for International Tables G. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to coreCIF and updated _definition.update dates.
vaitkus
reviewed
Mar 13, 2024
Replace other instances of U+2019 RIGHT SINGLE QUOTATION MARK with ASCII ' in this file Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Agree to improved layout Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
- incorporating suggested review changes from Antanas.
vaitkus
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many style changes and typos. Sorry for the number in a single PR, but most should be uncontroversial.
More significant changes:
save__space_group_magn.hall_symbol -> save_space_group_magn.hall_symbol (i.e. just one underscore).
"Analogous tags" for symCIF changed to coreCIF where they are present in the current core dictionary.
Definition updates changed to today's date (2024-03-13) only for these symCIF/coreCIF changes.