Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix recording #276

Merged
merged 4 commits into from
Oct 1, 2024
Merged

bug fix recording #276

merged 4 commits into from
Oct 1, 2024

Conversation

bukhosi-eugene-mpande
Copy link
Contributor

…failure

Pull Request

Description:

bug fix recording and updated node version for the deployment to stop the failure on main

Related Issues:

[Reference any related issues or documents.]

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Additional Notes:

[Any additional information that may be helpful for reviewers.]

@bukhosi-eugene-mpande bukhosi-eugene-mpande changed the title bug fix recording and updated node version for the deployment to stop … bug fix recording Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (1d10d4e) to head (22da6b6).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/src/lib/server/utils/interactive.ts 0.00% 10 Missing ⚠️
[...rkspace]/interactive/[interactive]/+page.server.ts](https://app.codecov.io/gh/COS301-SE-2024/ClassConnect/pull/276?src=pr&el=tree&filepath=src%2Fsrc%2Froutes%2F%28app%29%2Fworkspaces%2F%5Bworkspace%5D%2Finteractive%2F%5Binteractive%5D%2F%2Bpage.server.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COS301-SE-2024#diff-c3JjL3NyYy9yb3V0ZXMvKGFwcCkvd29ya3NwYWNlcy9bd29ya3NwYWNlXS9pbnRlcmFjdGl2ZS9baW50ZXJhY3RpdmVdLytwYWdlLnNlcnZlci50cw==) 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #276      +/-   ##
===========================================
- Coverage    33.01%   32.94%   -0.07%     
===========================================
  Files           66       66              
  Lines         4243     4252       +9     
  Branches       321      321              
===========================================
  Hits          1401     1401              
- Misses        2842     2851       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Ashley-Kapaso Ashley-Kapaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for the fix

Copy link
Contributor

@JoshuaTristanWereley JoshuaTristanWereley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@JoshuaTristanWereley JoshuaTristanWereley merged commit 867fb56 into develop Oct 1, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants