Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo 4 PR into Main #238

Merged
merged 397 commits into from
Sep 30, 2024
Merged

Demo 4 PR into Main #238

merged 397 commits into from
Sep 30, 2024

Conversation

Yeshlen
Copy link
Contributor

@Yeshlen Yeshlen commented Sep 30, 2024

No description provided.

Yeshlen and others added 30 commits September 25, 2024 22:35
Added blocks around each graph
Updating visualization page
Updating visualization page
Visualization update
Now I just need to make sure that I get all the fields I need
Got the grid layout in a better style
Fixed the layout style
I was  getting all the fields and changing things in the API
Copy link

gitguardian bot commented Sep 30, 2024

⚠️ GitGuardian has uncovered 18 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13964749 Triggered Generic Password 50c97c9 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 50c97c9 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 50c97c9 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 50c97c9 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 50c97c9 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 50c97c9 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 95c6ae2 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 95c6ae2 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 95c6ae2 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 95c6ae2 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 95c6ae2 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password 95c6ae2 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password ce6eea8 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password ce6eea8 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password ce6eea8 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password ce6eea8 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password ce6eea8 gnd-admin/src/app/register/register.component.spec.ts View secret
13964749 Triggered Generic Password ce6eea8 gnd-admin/src/app/register/register.component.spec.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gdpr-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 5:59am
gnd-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 5:59am

@Yeshlen Yeshlen requested a review from paul-nhlapo September 30, 2024 06:05
Copy link
Contributor

@paul-nhlapo paul-nhlapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@paul-nhlapo paul-nhlapo merged commit 1f3f017 into main Sep 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants