-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/composite queries backend #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters to allow for subqueries in WHERE clauses Co-authored-by: Graeme Blain <GremBleen@users.noreply.github.com>
…of null being 'object' in Typescript
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #416 +/- ##
==========================================
- Coverage 76.25% 75.88% -0.38%
==========================================
Files 112 113 +1
Lines 8397 8458 +61
Branches 845 742 -103
==========================================
+ Hits 6403 6418 +15
- Misses 1961 2037 +76
+ Partials 33 3 -30 ☔ View full report in Codecov by Sentry. |
u22738917
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint details:
Request:
PUT to .../api/query-management/get-subqueries
Auth
The currently signed-in user's JWT should be sent through as a bearer token
Body contents:
Response:
an object containing 'query_data' which is an array of saved_queries each with:
Added IN as a comparison operator in the intermediate JSON
Added QueryParams as a possible type of primitive condition value in the intermediate JSON
Adjusted both MySqlJsonConverter and PostgresJsonConverter to deal with QueryParams in conditions recursively
Adjusted QueryManagement to strip PageParams and SortParams from queries before they are saved so as to allow them to be used as subqueries
Adjusted MySqlQueryHandler and PostgresQueryHandler to throw subquery-specific errors for the frontend to handle
Added additional error-checking and toast error notifications to TableResponse on the frontend so as to display the aforementioned errors from the backend, so users can adjust their subqueries
Fixed the issue where the Cypress binary was missing causing the Cypress CI tests to fail