Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type-checking by explicitly specifying include in tsconfig.json #10

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

rileychh
Copy link
Member

@rileychh rileychh commented Aug 28, 2024

這個 PR 修好了 type-check 腳本因為沒有包含 .vitepress 目錄的關係,找不到任何可以檢查的檔案而失敗。

此外,tsconfig.jsonpath 設定和 package.json 的不符,這樣會讓編輯器建議不正確的匯入路徑,我也順便修好了。

由於在 tsconfig.json 中已經設定 noEmit,所以 type-check 時不需要再指定 --noEmit

@rileychh rileychh changed the title explicit-tsconfig-include Fix type-checking by explicitly specifying include in tsconfig.json Aug 28, 2024
@rileychh rileychh marked this pull request as ready for review August 28, 2024 10:30
@rileychh rileychh self-assigned this Aug 29, 2024
Copy link
Contributor

@mirumodapon mirumodapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rileychh rileychh merged commit 0c1e99e into main Aug 31, 2024
1 check passed
@rileychh rileychh deleted the explicit-tsconfig-include branch August 31, 2024 05:02
@rileychh rileychh restored the explicit-tsconfig-include branch August 31, 2024 05:02
@rileychh rileychh deleted the explicit-tsconfig-include branch August 31, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants