-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event date and location #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileychh
force-pushed
the
event-page
branch
2 times, most recently
from
September 5, 2024 11:22
02b930b
to
cefcc96
Compare
rileychh
commented
Sep 5, 2024
`vite` is added for type definitions of `import.meta.env`.
mirumodapon
requested changes
Sep 7, 2024
mirumodapon
approved these changes
Sep 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (交通資訊待捕)
This was referenced Sep 9, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這份 PR 在「活動資訊」頁面增加了活動的日期和位置。
日期資料會從
#data/conference.ts
匯入,並用toLocaleDateString
轉換成系統的日期格式。下方有加入各式常見日曆的按鈕,在點擊時會匯入calender-link
模組並產生對應的連結,然後在新分頁打開。位置資訊的內文中有場地的地址和地圖。地址旁的複製按鈕在瀏覽器支援時會出現,點擊後會複製場地地址到剪貼簿,並替換圖示成綠色勾勾。用 Leaflet 製作的地圖只會在客戶端出現,
利用(現在是同步元件了),並且在白色和黑色主題下有不同的配色。地圖中載入完成後會置中場地(臺科大),並且標記研揚大樓和綜合研究大樓的位置,觸控或懸停在建築物上就可以看見建築物的名字。<Suspense>
在網頁 FCP 後異步載入這是 #7 的進度。