Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resize images & fix Carousel (拆掉 commit 再重新 push) #25

Merged
merged 5 commits into from
Dec 8, 2024

Conversation

bessyhuang
Copy link
Contributor

No description provided.

Copy link
Member

@rileychh rileychh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起來很棒,只有一些小問題。能讓滑鼠在 Swiper 上有「左、右」箭頭能點擊嗎?這樣會比較容易瀏覽相片。

另外,在手機上相片好像太小張了!試試看能不能讓元件的大小根據視窗的寬度縮放(或者在寬度不足時減少一次瀏覽的張數)。

components/FlickrCarousel.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@mirumodapon mirumodapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is better if there is dynamic import at swiper image.

@bessyhuang
Copy link
Contributor Author

image
圖片顯示 待修

@rileychh
Copy link
Member

rileychh commented Oct 7, 2024

LGTM, it is better if there is dynamic import at swiper image.

為什麼動態引入會比較好呢?用靜態引入可以減少需要的 JavaScript 程式量。

components/FlickrCarousel.vue Show resolved Hide resolved
components/FlickrCarousel.vue Outdated Show resolved Hide resolved
@bessyhuang bessyhuang mentioned this pull request Dec 1, 2024
@rileychh rileychh merged commit c3dae0a into main Dec 8, 2024
1 check passed
@rileychh rileychh deleted the about-us branch December 8, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants