Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion SeaIce_Plot_Example #369

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anton-seaice
Copy link
Collaborator

Thanks @rbeucher . It looks like this was based on an older version of this recipe, not including the updates (#294) from the hackathon last September.

Do you have someone to merge with the latest version of the recipe? Or shall I do that?

@rbeucher
Copy link
Contributor Author

Feel free to do it. I took a cautious approach and decided not to merge changes from main

@anton-seaice anton-seaice marked this pull request as draft June 21, 2024 05:42
@anton-seaice anton-seaice self-assigned this Jun 21, 2024
@anton-seaice
Copy link
Collaborator

This PR is blocked on OM4_025.JRA_RYF not being in the Intake Catalog

@adele-morrison : Is this experiment appropriate to add to the catalog? The criteria are loosely:

  • This data product is stable (unlikely to change substantially or move)
  • This data product is of use to the broader community
  • This data product is documented:
  • This data product is licensed under
  • Those who want to access this data can be added to the project that houses it

@adele-morrison
Copy link
Collaborator

Yes, sure let's include OM4_025.JRA_RYF in the Intake Catalog. Sounds like it's at least worth keeping for the next year for OM3 development comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants