Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake conversion Transport_Through_Straits #372

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

rbeucher
Copy link
Contributor

@rbeucher rbeucher commented Jun 6, 2024

Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.

A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Thomas-Moore-Creative Thomas-Moore-Creative self-assigned this Jul 1, 2024
@Thomas-Moore-Creative
Copy link
Collaborator

Have reviewed and made the following changes for further review by @anton-seaice.

These changes include:

  • collapsing lines of code removing some of the intermediate “cat” and “search” objects
  • removed import pandas as pd as not needed
  • moved catalog = intake.cat.access_nri to it's own cell to separate it from the imports
  • removed some of the magics at the top of the import cell
  • tcp://10.6.58.34:8786 removed from client
  • added threads_per_worker=1 to the client to deal with problems possibly related to Getting NETCDF: HDF error while writing a NetCDF file opened using open_mfdataset pydata/xarray#8207

The updated code runs as the original code did, including this erroneous result for Lombok Strait.
CleanShot 2024-07-01 at 16 57 05@2x

Copy link
Collaborator

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @Thomas-Moore-Creative !

@navidcy
Copy link
Collaborator

navidcy commented Jul 3, 2024

nice job!

@navidcy navidcy merged commit f88e1d8 into main Jul 3, 2024
3 checks passed
@navidcy navidcy deleted the INTAKE_Transport_Through_Straits branch July 3, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants