Add sector-based sea ice analysis (#393) #459
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I updated the branch with changes that happened in main. You should pull the changes before you continue edit the notebook otherwise merge conflicts might created. |
|
Just noting that the experiment data referenced in this notebook appears to be available via |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-09-17T03:29:23Z We call them "recipes", not "scripts". Could you please rephrase? Also, define SIA in the text as well, at least the first time. |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-09-17T03:29:24Z Could you add a link to the reference? E.g., |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-09-17T03:29:24Z Why we have numbers |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-09-17T03:29:25Z put this cell at the top |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-09-17T03:29:26Z
Let's make a different step for the conversion, e.g.,
OM2_SIC = OM2_SIC.fillna(0) OM2_SIC = OM2_SIC* 1.e-6 # convert m^2 -> km^2
(Also, not 1.e-6 since what does . add here?) |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-09-17T03:29:27Z Line #6. CDR_area = CDR_area / 1000 I don't understand why divide by 1000 here anton-seaice commented on 2024-09-18T06:46:53Z It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago navidcy commented on 2024-10-04T04:44:53Z So is this a unit conversion from m^2 -> km^2...? no... Let's add a comment that explains?
Or, if the |
|
View / edit / reply to this conversation on ReviewNB navidcy commented on 2024-09-17T03:29:27Z Line #23. OM2_SIA_sectors = xr.DataArray(OM2_SIA_sectors,dims=["sector","time"],coords=[list(sectors.keys()),OM2_SIC.coords["time"].values]) here, as well as previous line add space after commas? |
|
It a fairly arbitrary definition in the .dat file, it suited whomever made the file many years ago View entire conversation on ReviewNB |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-09-18T06:55:57Z We've had a glow up of recipe names / titles recently, we've got a
So I think this recipe could be
navidcy commented on 2024-10-04T04:45:14Z What is a "glow up"? |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-09-18T06:55:58Z I think we should mention here atleast that the obs start in 1979 ? |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-09-18T06:55:58Z Line #2. client=Client(threads_per_worker=1)
|
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-09-18T06:55:59Z tarea is just the cell area |
|
View / edit / reply to this conversation on ReviewNB anton-seaice commented on 2024-09-18T06:56:00Z Line #8. CDR_SIC = CDR_SIC.cdr_seaice_conc_monthly.sel(time=slice(str(start_year)+'-01-01', str(end_year)+'-12-31'), drop=True) you can normally just |
What's a "glow up"? I suggest |
|
@serenaschroeter are you happy with dealing with the comments above? would you like help? |
|
So is this a unit conversion from m^2 -> km^2...? no... Let's add a comment that explains?
Or, if the View entire conversation on ReviewNB |
|
What is a "glow up"? View entire conversation on ReviewNB |
Code to calculate and visualise sector-based sea ice metrics for Southern Hemisphere based on sector definitions in Raphael & Hobbs, 2014. Obtains NSIDC observational estimate directly from PolarWatch, and uses COSIMA Cookbook to access model data.
Closes #393