Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to calculate global volume mean temperature and same valid for salinity #74

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

abhisheksavita
Copy link

…same valid for salinity.

@rmholmes rmholmes self-assigned this Apr 6, 2020
@angus-g angus-g linked an issue Apr 6, 2020 that may be closed by this pull request
@rmholmes
Copy link
Collaborator

rmholmes commented Apr 6, 2020

Hi @abhisheksavita, this looks good overall and runs fine on my setup. Here are some comments:

  • It would be great if you could include a bit more documentation explaining what you are doing at each step. For example, please add a description below the title of what the notebook does. Also, can you explain what the weighting function is doing.
  • Please remove the code blocks that only contain commented code.
  • Your Volume_mean_temp is computed twice. Please remove cell 12.
  • Can you also explain what you are doing in the final code block with the plotting. Why compare the unweighted and weighted means?

I note also that the global averaged temperature and salinity variables are also included in the output of most runs in ocean_scalar.nc as the temp_global_ave and salt_global_ave variables (you could check your calculation by also plotting these variables on the time series plot). However, this script is useful to show how those are calculated.

@rmholmes
Copy link
Collaborator

rmholmes commented Apr 6, 2020

Once you've made your changes all you have to do is commit them and then push them back up to your global_TS_Change branch on github and this pull request will be automatically updated.

@navidcy navidcy changed the title This is a new script to calculate global volume mean temperature and … Script to calculate global volume mean temperature and same valid for salinity Apr 6, 2020
@rmholmes
Copy link
Collaborator

rmholmes commented Apr 8, 2020

Looks good @abhisheksavita. Runs fine. Thanks. Interesting that there is a difference between the offline and online calculation (although it's in the fifth decimal place for temperature). I guess this is coming from the neglect of temporal correlations at time-scales less than your monthly average offline diagnostics as I mentioned in COSIMA/access-om2#142

@rmholmes rmholmes merged commit 652d348 into COSIMA:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Ocean Volumetric Temperature and Salinity Change
2 participants