Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repeated <stream_info name="rof.iaf_jra"> in drof.streams.xml #29

Closed
aekiss opened this issue Aug 29, 2024 · 2 comments
Closed

repeated <stream_info name="rof.iaf_jra"> in drof.streams.xml #29

aekiss opened this issue Aug 29, 2024 · 2 comments
Assignees
@ezhilsabareesh8
Labels
bug Something isn't working

Comments

@aekiss
Copy link
Contributor

aekiss commented Aug 29, 2024

generate_xml_drof.py uses

<stream_info name="rof.iaf_jra">

for both friver and licalvf. Presumably this is a bad idea?

Related: #27
@aekiss
Copy link
Contributor Author

aekiss commented Aug 29, 2024 •
edited
Loading

Non-uniqueness bugs like these can be avoided if a dict is used instead of a list here, with the stream name being the dict key.

@aekiss aekiss added the bug Something isn't working label Aug 29, 2024
This was referenced Aug 29, 2024
Closed
Closed
This was referenced Aug 29, 2024
Closed
Merged
@dougiesquire
Copy link
Collaborator

Closed by #31

aekiss added a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 16, 2024
@aekiss
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
e1e7e2d 
…-scripts#27, COSIMA/om3-scripts#29
@aekiss aekiss mentioned this issue Sep 16, 2024
Merged
aekiss added a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 20, 2024
@aekiss
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
db5e8e8 
…-scripts#27, COSIMA/om3-scripts#29
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
@aekiss @anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
d9dbecf 
…-scripts#27, COSIMA/om3-scripts#29
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
@aekiss @anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
b0f70f5 
…-scripts#27, COSIMA/om3-scripts#29
anton-seaice added a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
@anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208 COSIMA/om3-…
9150c33 
…scripts#27 COSIMA/om3-scripts#29
anton-seaice added a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 25, 2024
@anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208 COSIMA/om3-…
b6ee32a 
…scripts#27 COSIMA/om3-scripts#29
anton-seaice added a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 26, 2024
@anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208 COSIMA/om3-…
97faf42 
…scripts#27 COSIMA/om3-scripts#29
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 26, 2024
@aekiss @anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
fd44352 
…-scripts#27, COSIMA/om3-scripts#29
anton-seaice pushed a commit to ACCESS-NRI/access-om3-configs that referenced this issue Sep 26, 2024
@aekiss @anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
e571fde 
…-scripts#27, COSIMA/om3-scripts#29
anton-seaice pushed a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Sep 26, 2024
@aekiss @anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
01906c2 
…-scripts#27, COSIMA/om3-scripts#29
anton-seaice pushed a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Sep 30, 2024
@aekiss @anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208, COSIMA/om3…
0588442 
…-scripts#27, COSIMA/om3-scripts#29
anton-seaice added a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Oct 1, 2024
@anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208 COSIMA/om3-…
8fd5274 
…scripts#27 COSIMA/om3-scripts#29
anton-seaice added a commit to ACCESS-NRI/access-om3-wav-configs that referenced this issue Oct 3, 2024
@anton-seaice
update datm and drof streams to fix COSIMA/access-om3#208 COSIMA/om3-…
dbd7b9f 
…scripts#27 COSIMA/om3-scripts#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezhilsabareesh8 ezhilsabareesh8

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aekiss @dougiesquire @ezhilsabareesh8