Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generate_wombatlite_ic.py script #23

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

dougiesquire
Copy link
Collaborator

This PR adds a simple script for generating the ACCESS-OM3 WOMBATlite initial conditions for those tracers that are initalised to constants (a la ACCESS-OM2).

Copy link
Contributor

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this had an example use it would be clearer what grid file was needed etc .

In /g/data/vk83/configurations/inputs/access-om3/wombat/initial_conditions/global.1deg/2024.04.02/init_ocean_wombatlite.res.nc, there is a time dimension. Is that needed ?

It looks like this needs ocean initial conditions as a template? If that is true, that should be clearer in the description

Also, cchecker.py shows many things but maybe these are worth setting:

variable "caco3" missing the following attributes:
* coverage_content_type
* standard_name

variable "caco3_sediment" missing the following attributes:
* coverage_content_type
* standard_name

variable "det" missing the following attributes:
* coverage_content_type
* standard_name

variable "det_sediment" missing the following attributes:
* coverage_content_type
* standard_name

variable "phy" missing the following attributes:
* coverage_content_type
* standard_name

variable "time" missing the following attributes:
* standard_name

variable "zoo" missing the following attributes:
* coverage_content_type
* standard_name
*```

@dougiesquire
Copy link
Collaborator Author

Also, cchecker.py shows many things but maybe these are worth setting:

variable "caco3" missing the following attributes:
* coverage_content_type
* standard_name

What is coverage_content_type? I don't think many of these variables have valid CF standard names.

Copy link
Contributor

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Co-authored-by: Anton Steketee <79179784+anton-seaice@users.noreply.github.com>
@dougiesquire dougiesquire merged commit 4c01538 into main Aug 26, 2024
4 checks passed
@dougiesquire dougiesquire deleted the add_wombat_ic_generation branch August 26, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants