-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user customisation of columns in bpp
and bcm
tables
#673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiebreivik
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing! We can merge this in for now but we should be sure to add in some docs for providing the kwargs for the columns to the evolve call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two arguments to
Evolve.evolve()
,bpp_columns
andbcm_columns
. Users can specify a list of columns to include in either table, by default it will use the current setup so no breaking changes with this 😅 I've made the changes directly in the Fortran as well so this will perhaps cut down on RAM usage during the run.The only change I made that alters the default behaviour is to report
kstar_x
andevol_type
as integers instead of floats, which I think makes sense?(Selfishly motivated by TomWagg/cogsworth#86 🙃)
Implementation details
The way it works is:
writetab
(new function that combineswritebpp
andwritebcm
in a simpler way), access the specific variables in the order the inds specifyThis means I had to define some new variables in
const_bse.h
and also change the calling ofwritebpp
andwritebcm
everywhere.Demo
Default behaviour
Specifying certain columns