-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/oidcs-based-authentication #60
base: development
Are you sure you want to change the base?
Conversation
auth/auth.go
Outdated
COOKIE_ENCRYPTION_KEY_LENGTH = 32 | ||
COOKIE_SECRET_KEY_LENGHT = 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe lat the user specify longer keys if they wish?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already the strongest key: as specified in the gorilla session docs:
It is recommended to use an authentication key with 32 or 64 bytes. The encryption key, if set, must be either 16, 24, or 32 bytes to select AES-128, AES-192, or AES-256 modes.
https://pkg.go.dev/github.com/gorilla/sessions#NewCookieStore
auth/context.go
Outdated
if !exists { | ||
return []string{} | ||
} | ||
groups, ok := permissions.([]string) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't cast
No description provided.