Feature/92 add playbook action step typ to executor #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartendeKruijf
force-pushed
the
feature/92-add-playbook-action-step-typ-to-executor
branch
2 times, most recently
from
baca75e
to
dd2f898
Compare
|
I think this looks pretty good. It's been a while since I looked at the source. Does it already actually execute the playbook-action step with this PR? Or is this just preparation? |
hidde-jan
reviewed
Apr 9, 2024
test/unittest/mocks/mock_executor/playbook_action/mock_playbook_action_executor.go
Outdated
Show resolved
Hide resolved
|
Oops, I accidentally pulled in the changes from development. Maybe you'd rather rebase instead. |
MaartendeKruijf
force-pushed
the
feature/92-add-playbook-action-step-typ-to-executor
branch
2 times, most recently
from
d0df759
to
8f332c6
Compare
|
@hidde-jan It's final now I've added the call to the executor from the decomposer |
MaartendeKruijf
force-pushed
the
feature/92-add-playbook-action-step-typ-to-executor
branch
from
c343dfb
to
5885099
Compare
MaartendeKruijf
deleted the
feature/92-add-playbook-action-step-typ-to-executor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.