Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/74 send final ack after receiving result #121

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Bugfix/74 send final ack after receiving result #121

merged 8 commits into from
Apr 8, 2024

Conversation

xncz8h
Copy link
Collaborator

@xncz8h xncz8h commented Apr 8, 2024

Fixes issue #74

  • Fixes an issue where fin capability could not receive messages due to colliding names.
  • Sends final ack to fin when a results has been received
  • Updated tests to also expect an ack to be send

@xncz8h xncz8h added the bug Something isn't working label Apr 8, 2024
@xncz8h xncz8h linked an issue Apr 8, 2024 that may be closed by this pull request
Fin protocol needs to send a final ack when receiving the result structure #74
Closed
@MaartendeKruijf MaartendeKruijf merged commit 6458528 into development Apr 8, 2024
9 checks passed
@MaartendeKruijf MaartendeKruijf deleted the bugfix/74-send-final-ack-after-receiving-result branch April 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaartendeKruijf MaartendeKruijf MaartendeKruijf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fin protocol needs to send a final ack when receiving the result structure
3 participants
@xncz8h @MaartendeKruijf @ivokroskinski