Added HTTP_SKIP_CERT_VALIDATION and http implementation to http util #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RabbITCybErSeC
previously approved these changes
May 8, 2024
…ng a insecure endpoint
MaartendeKruijf
commented
May 8, 2024
|
|
||
| response, err := httpRequest.Request(httpOptions) | ||
| t.Log(string(response)) | ||
| if err == nil { |
There was a problem hiding this comment.
use assert here
| httpRequest.SkipCertificateValidation(true) | ||
| response, err := httpRequest.Request(httpOptions) | ||
| t.Log(string(response)) | ||
| if err != nil { |
There was a problem hiding this comment.
assert err equals nil
| @@ -34,6 +34,61 @@ type httpBinResponseBody struct { | |||
| } | |||
|
|
|||
| // Test general http options, we do not check responses body, as these are variable for the general connection tests | |||
|
|
|||
| func TestInsecureHTTPConnection(t *testing.T) { | |||
There was a problem hiding this comment.
Move test to integration tests
RabbITCybErSeC
approved these changes
May 8, 2024
RabbITCybErSeC
deleted the
feature/146-allow-self-signed-certificate-from-environment-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.