Feature/93 expand executor interface #94
Conversation
MaartendeKruijf
force-pushed
the
feature/93-expand-executor-interface
branch
from
7c0300c
to
170a612
Compare
internal/decomposer/decomposer.go
Outdated
| case "action": | ||
| return decomposer.ExecuteActionStep(step, variables) | ||
| case cacao.StepTypeAction: | ||
| details := action.StepDetails{Step: step, Targets: decomposer.playbook.TargetDefinitions, Auth: decomposer.playbook.AuthenticationInfoDefinitions, Agent: decomposer.playbook.AgentDefinitions[step.Agent], Variables: variables} |
There was a problem hiding this comment.
I personally find slightly confusing the naming of the struct fields here, because some are step-specific and some are not.
In StepDetails, we are inserting all targets definitions and all authinfo. I would then name the struct fields something more like PlaybookTargets, PlaybookAuthInfoDefinitions, and StepAgent.
There was a problem hiding this comment.
maybe playbook metadata is better?
There was a problem hiding this comment.
Not sure what you mean. You mean instead of StepDetails? The role of the "details" variable is still to provide step details and related step context right? And also there's already the "metadata" var being used.
There was a problem hiding this comment.
can you also make this line shorter?
internal/decomposer/decomposer.go
Outdated
| case "action": | ||
| return decomposer.ExecuteActionStep(step, variables) | ||
| case cacao.StepTypeAction: | ||
| details := action.StepDetails{Step: step, Targets: decomposer.playbook.TargetDefinitions, Auth: decomposer.playbook.AuthenticationInfoDefinitions, Agent: decomposer.playbook.AgentDefinitions[step.Agent], Variables: variables} |
There was a problem hiding this comment.
can you also make this line shorter?
No description provided.