Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GetField API (breaking changes) #37

Merged
merged 33 commits into from
Sep 4, 2024

Conversation

adriaan-niess
Copy link
Member

Improve GetField API (not all changes completed yet)

Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
@adriaan-niess adriaan-niess changed the title Feat/get field Improve GetField API Aug 23, 2024
@adriaan-niess adriaan-niess changed the title Improve GetField API Improve GetField API (breaking changes) Aug 23, 2024
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
@adriaan-niess adriaan-niess requested a review from nayakned August 28, 2024 12:21
@adriaan-niess
Copy link
Member Author

@nayakned Can you review if the CAN Talker/Listener apps still work as expected?

Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
Copy link
Collaborator

@nayakned nayakned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nayakned nayakned merged commit 5a51e07 into COVESA:main Sep 4, 2024
1 check passed
@nayakned nayakned deleted the feat/get-field branch September 4, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants