Remove clear_multicast_endpoints() in unsubscribe. #651
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhzarj
changed the title
The clearing multicast endpoints stops any multicast messages receiving without recovering if TTLs are not expiring. Co-authored-by: Aram Khzarjyan <aram.khzarjyan@mercedes-benz.com> Signed-off-by: Gunnar Andersson <gunnar.andersson@mercedes-benz.com>
|
PR looks good to me. |
|
Hi @akhzarj could you give an example of how we can reproduce this issue? |
|
if one wants to unsubscribe to a set of service/instance, why would you want to receive any more messages from that specific endpoint? |
|
Yes in your case that true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Aram Khzarjyan Aram.Khzarjyan@mercedes-benz.com, MBition GmbH.
Remove clear_multicast_endpoints() in unsubscribe. #651
The clearing multicast endpoints stops any multicast messages
receiving without recovering if TTLs are not expiring.
The program was tested solely for our own use cases, which might differ from yours.
The submission is provided under the main project license (LICENSE file in root of project).
Provider Information