Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log offers on first occurrence in routing manager #728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

falk-haleytek
Copy link
Contributor

For debugging purposes, the routing manager has been updated to log the first time a new service is detected to be offered.

falk-haleytek and others added 2 commits June 25, 2024 08:31
For debugging purposes, the routing manager has been updated to log
the first time a new service is detected to be offered.
@@ -1084,6 +1084,13 @@ routing_manager_stub::on_net_state_change(

void routing_manager_stub::on_offer_service(client_t _client,
service_t _service, instance_t _instance, major_version_t _major, minor_version_t _minor) {

VSOMEIP_DEBUG << "ON_OFFER_SERVICE("
Copy link
Contributor

@goncaloalmeida goncaloalmeida Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use func name, for example:
VSOMEIP_DEBUG << __ func __ << ": ..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@falk-haleytek if you could make this change also, i would merge this too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 4211311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants