Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the datatypes HSVColor and DateTime. #79

Closed

Conversation

oliveirarleo
Copy link
Contributor

Adding the datatypes HSVColor and DateTime.

The type DateTime is added according to the ISO 8601
The type HSVColor is added according to the HSL Format
resolves #76

The type DateTime is added according to the [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601)
The type HSVColor is added according to the [HSL Format](https://drafts.csswg.org/css-color/#the-hsl-notation)
Copy link
Contributor

@barbieri barbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, let's see what @gunnarx and @Floix think

@barbieri
Copy link
Contributor

barbieri commented Jul 2, 2021

@oliveirarleo please add tests/model/test_contants.py covering them

@SebastianSchildt
Copy link
Collaborator

If theres is consensus to merge I will not block, but I feel this is the "most wrong" way to add units. We create a randomly curated list of "allowed" units, some of which are in VSS and some not, and probably the first thing everybody needs to to, once he uses vSS besides the standard catalogue is hacking in more units in his fork (which I already did, and which also ultimately leads to this PR)

Anyway, my thoughts on this are here already: #76 (comment)

@danielwilms
Copy link
Contributor

@barbieri: create an issue

  • for datatypes and
  • a second one for units (< how to deal with additional units curated list or not)
  • list possible datatypes as start to be more "future proof"

@danielwilms: create issue for units mismatch code vs. docs

@barbieri
Copy link
Contributor

@danielwilms created #89 and #91 as requested. Since you did not create the issue on the units mismatch, I did that as #90.

@danielwilms
Copy link
Contributor

@barbieri That's generous ;) thanks a lot!

@gunnarx gunnarx added the HOLD label Jul 22, 2021
@danielwilms
Copy link
Contributor

@gunnarx, please close the PR

@gunnarx
Copy link

gunnarx commented Sep 7, 2021

Refer to tickets for more info.

@gunnarx gunnarx closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the Unit and VSSDataType to support custom types and units
5 participants