-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the datatypes HSVColor and DateTime. #79
Conversation
The type DateTime is added according to the [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601) The type HSVColor is added according to the [HSL Format](https://drafts.csswg.org/css-color/#the-hsl-notation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oliveirarleo please add |
If theres is consensus to merge I will not block, but I feel this is the "most wrong" way to add units. We create a randomly curated list of "allowed" units, some of which are in VSS and some not, and probably the first thing everybody needs to to, once he uses vSS besides the standard catalogue is hacking in more units in his fork (which I already did, and which also ultimately leads to this PR) Anyway, my thoughts on this are here already: #76 (comment) |
@barbieri: create an issue
@danielwilms: create issue for units mismatch code vs. docs |
@danielwilms created #89 and #91 as requested. Since you did not create the issue on the units mismatch, I did that as #90. |
@barbieri That's generous ;) thanks a lot! |
@gunnarx, please close the PR |
Refer to tickets for more info. |
Adding the datatypes HSVColor and DateTime.
The type DateTime is added according to the ISO 8601
The type HSVColor is added according to the HSL Format
resolves #76